[elbe-devel] [PATCH 09/75] commands fetch_initvm_pkgs: Fix Pylint

[Torben Hohn]

On Mon, May 25, 2020 at 11:42:02AM -0400, Olivier Dion wrote:
> 26:0: R0914: (too-many-locals)
> 26:0: R0912: (too-many-branches)
> 26:0: R0915: (too-many-statements)
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> ---
>  elbepack/commands/fetch_initvm_pkgs.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/elbepack/commands/fetch_initvm_pkgs.py b/elbepack/commands/fetch_initvm_pkgs.py
> index 992f1af9..f47c6887 100644
> --- a/elbepack/commands/fetch_initvm_pkgs.py
> +++ b/elbepack/commands/fetch_initvm_pkgs.py
> @@ -24,6 +24,9 @@ from elbepack.aptpkgutils import fetch_binary
>  
>  
>  def run_command(argv):
> +    # pylint: disable=too-many-locals
> +    # pylint: disable=too-many-branches
> +    # pylint: disable=too-many-statements

i am not so happy, that we deactivate these here.
this allows this function to go out of hand later on.

This function seems to be pretty reasonable
Maybe we want to increase the values ?

sadly, this is not possible on a per file basis with "# pylint:"
But maybe we want to have higher values in elbepack/commands
When we have one Test per pylint file ?

But lets not block this queue for now.

Acked-by: Torben Hohn <torben.hohn at linutronix.de>


>      oparser = OptionParser(
>          usage="usage: %prog fetch_initvm_pkgs [options] <xmlfile>")
>  
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner