[elbe-devel] [PATCH 09/75] commands fetch_initvm_pkgs: Fix Pylint

[Olivier Dion]

On Fri, 29 May 2020, Torben Hohn <torben.hohn at linutronix.de> wrote:
> On Mon, May 25, 2020 at 11:42:02AM -0400, Olivier Dion wrote:
>> 26:0: R0914: (too-many-locals)
>> 26:0: R0912: (too-many-branches)
>> 26:0: R0915: (too-many-statements)
>> 
>> Signed-off-by: Olivier Dion <dion at linutronix.de>
>> ---
>>  elbepack/commands/fetch_initvm_pkgs.py | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/elbepack/commands/fetch_initvm_pkgs.py b/elbepack/commands/fetch_initvm_pkgs.py
>> index 992f1af9..f47c6887 100644
>> --- a/elbepack/commands/fetch_initvm_pkgs.py
>> +++ b/elbepack/commands/fetch_initvm_pkgs.py
>> @@ -24,6 +24,9 @@ from elbepack.aptpkgutils import fetch_binary
>>  
>>  
>>  def run_command(argv):
>> +    # pylint: disable=too-many-locals
>> +    # pylint: disable=too-many-branches
>> +    # pylint: disable=too-many-statements
>
> i am not so happy, that we deactivate these here.
> this allows this function to go out of hand later on.
>
> This function seems to be pretty reasonable
> Maybe we want to increase the values ?
>
> sadly, this is not possible on a per file basis with "# pylint:"
> But maybe we want to have higher values in elbepack/commands
> When we have one Test per pylint file ?

With parameterized tests it will be very easy to do that.  i.e. very
fine grained pylint rule for individual directories/files.

-- 
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen